Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Added JSON linter to connection edit / add UI #28583

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

maggesssss
Copy link
Contributor

I have a proposal for an improvement on the connection edit / add UI.

conn.extra only allows valid JSON.
On the UI, the widget is a simple TextArea without linting capabilities.

I have added the CodeMirror as already used by trigger dag view also on the connection edit / add UI.
This provides a better visual feedback.

Additionally when editing a connection, JSON data of conn.extra is displayed idented instead of a single line:
grafik

This is currently just a proposal and I would like to hear some feedback.

…nection edit screen, existing extra data will be displayed idented
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Dec 25, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 25, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@maggesssss maggesssss marked this pull request as ready for review December 25, 2022 12:37
@eladkal eladkal added this to the Airflow 2.6.0 milestone Dec 27, 2022
@bbovenzi bbovenzi merged commit b3fe6b4 into apache:main Jan 5, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 5, 2023

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues type:improvement Changelog: Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants