Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AwsToAwsBaseOperator #30044

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Add AwsToAwsBaseOperator #30044

merged 2 commits into from
Mar 14, 2023

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Mar 11, 2023

followup on #29452 (comment) This PR preserve all current behavior but add the needed interface to be used for other transfer operators

cc @1inuxoid @ferruzzi


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@eladkal eladkal requested a review from Taragolis March 11, 2023 14:48
@eladkal eladkal requested a review from o-nikolas as a code owner March 11, 2023 14:48
@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Mar 11, 2023
@eladkal eladkal force-pushed the dynamo branch 3 times, most recently from 6c3b152 to 29f2aaf Compare March 11, 2023 15:43
@eladkal eladkal changed the title Add BaseAwsToAwsTransferOperator Add AwsToAwsBaseOperator Mar 11, 2023
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a nitpick, otherwise LGTM

airflow/providers/amazon/aws/transfers/base.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/transfers/base.py Outdated Show resolved Hide resolved
followup on apache#29452 (comment)
This PR preserve all current behavior but add the needed interface to be used for other transfer operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants