Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable mode to CloudSQLExportInstanceOperator #30852

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

bkossakowska
Copy link
Contributor

Add deferrable mode to CloudSQLExportInstanceOperator


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member

potiuk commented Apr 26, 2023

static checlst/ tests failing :(

@eladkal
Copy link
Contributor

eladkal commented May 16, 2023

tests are still failing
@bkossakowska can you check it?

@bkossakowska bkossakowska marked this pull request as draft May 17, 2023 07:34
@bkossakowska bkossakowska force-pushed the cloud_sql_def branch 2 times, most recently from 46d21ae to d94894d Compare May 25, 2023 08:20
@bkossakowska bkossakowska marked this pull request as ready for review May 25, 2023 08:32
@bkossakowska
Copy link
Contributor Author

@eladkal
tests are passed

@potiuk
Copy link
Member

potiuk commented Jun 29, 2023

@pankajastro - any more comments?

Copy link
Member

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit c0eaa9b into apache:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants