Add Deferrable switch to SnowflakeSqlApiOperator #31596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:snowflake
uranusjr
reviewed
Jun 13, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
phanikumv
approved these changes
Jun 15, 2023
uranusjr
reviewed
Jun 16, 2023
Comment on lines
+274
to
+275
| resp = await response.json() | ||
| return self._process_response(status_code, resp) |
There was a problem hiding this comment.
I wonder if we should make the response body be fetched lazily, what could take a while (and might actually be the part worth deferring—not sure)
There was a problem hiding this comment.
@uranusjr I'm not sure I understand you completely, but based on what I got. The function get_sql_api_query_status_async is called indirectly when we are polling for the status of the query within triggered. So deferring it would not be ideal, right?
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
uranusjr
reviewed
Jun 16, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
utkarsharma2
force-pushed
the
DeferrableSnowflakeSqlApiOperator
branch
from
07d3fae
to
b39b57b
Compare
potiuk
approved these changes
Jul 3, 2023
|
I think you should rebase/solve conflicts on that one jsut to be sure. |
utkarsharma2
commented
Jul 4, 2023
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR donates the SnowflakeSqlApiOperator deferrable developed in astronomer-providers repo to Apache airflow.