-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow anonymous AWS access #31659
allow anonymous AWS access #31659
Conversation
fd2bd39
to
6e6a397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Should we document this somehow as well?
Good callout! I'd say yes :) |
@jedcunningham @vincbeck good call. added a sentence to the AWS connection docs. lmk how that looks |
Other than the static check failures, lgtm 👍 |
@melugoyal I'd suggest you set up the pre-commit hooks, they help catch these issues early 👍. |
1c46e41
to
1c54aa5
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Thanks @melugoyal! Congrats on your first commit 🎉 |
allow anonymous AWS access. this allows the consumer of any AWS operator to use the equivalent of
aws s3 cp <s3 path> . --no-sign-request
, to write a DAG that eg reads from a public S3 bucket without providing any credentials. to leverage this, an AWS connection can be created as such:this is necessary because botocore's
UNSIGNED
is not JSON-serializable, so usingbotocore.UNSIGNED
when instantiating the connection will cause the connection processing to fail. instead we can use a string in the connection instantiation and convert it to botocore's expected value later. more history about this issue here: boto/botocore#2442^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.