-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ChimeWebhookHook
#31939
Add ChimeWebhookHook
#31939
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! Thanks for the contribution Cary!
You can install pre-commit and enable it for commit/push in airflow to catch the static check failures (docs). You can also run the docs build locally too for just the Amazon provider package to iterate on those build failures (breeze build-docs --package-filter apache-airflow-providers-amazon
)
3869fc2
to
0e66783
Compare
…31457) Co-authored-by: Beata Kossakowska <bkossakowska@google.com> Co-authored-by: eladkal <45845474+eladkal@users.noreply.github.com>
…pache#31457)" (apache#31935) This reverts commit c7072c0.
Hey @cjames23 -> you need to update Basically "http" provider is seen as affected when any of the amazon code is changed, so needs to be added to the lists that are verified during tests. |
@potiuk is there a way to run selective checks locally with breeze? If I try to run it with pytest inside the breeze container I get an import error.
I want to test if for http do I need to set run-amazon-tests to true rather than false based on the latest error I am seeing from the last attempted run. |
ChimeWebhookHook
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Nice! Congrats. |
* Create ChimeWebhook Hook to send messages to chime room from Airflow. --------- Co-authored-by: Beata Kossakowska <109511937+bkossakowska@users.noreply.github.com> Co-authored-by: Beata Kossakowska <bkossakowska@google.com> Co-authored-by: eladkal <45845474+eladkal@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Creating a Hook to call a Chime Web Hook. This is preliminary work to be able to enable Chime notifications similar to #31273
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.