Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deferrable mode to S3KeysUnchangedSensor #31940

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Add deferrable mode to S3KeysUnchangedSensor #31940

merged 4 commits into from
Jun 29, 2023

Conversation

sunank200
Copy link
Collaborator

@sunank200 sunank200 commented Jun 15, 2023

This PR donates the following S3KeysUnchangedSensor with a deferrable mode, which checks for changes in the number of objects at prefix in the AWS S3 bucket and returns True if the inactivity period has passed with no increase in the number of objects. This was developed in astronomer-providers repository.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@o-nikolas
Copy link
Contributor

CC @syedahsn

airflow/providers/amazon/aws/hooks/s3.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/hooks/test_s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/hooks/test_s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/hooks/test_s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/hooks/test_s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/triggers/test_s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/triggers/test_s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/triggers/test_s3.py Outdated Show resolved Hide resolved
tests/providers/amazon/aws/triggers/test_s3.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/hooks/s3.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/sensors/s3.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/s3.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/s3.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/hooks/s3.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/hooks/s3.py Outdated Show resolved Hide resolved
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with getting that one in but maybe other more AWS knowledgeable people can chime in?

Copy link
Contributor

@syedahsn syedahsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@potiuk potiuk merged commit a46b942 into apache:main Jun 29, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants