add async wait method to the "with logging" aws utils #32055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also changed the status formatting in the logs so that it'd not be done if log level is not including INFO
boring-cyborg
bot
added
area:providers
provider:amazon-aws
syedahsn
reviewed
Jun 21, 2023
| @@ -68,23 +70,81 @@ def wait( | |||
| except WaiterError as error: | |||
| if "terminal failure" in str(error): | |||
| raise AirflowException(f"{failure_message}: {error}") | |||
| status_string = _format_status_string(status_args, error.last_response) | |||
| log.info("%s: %s", status_message, status_string) | |||
| log.info("%s: %s", status_message, _LazyStatusFormatter(status_args, error.last_response)) | |||
There was a problem hiding this comment.
Just so I'm understanding this correctly, the __str__ of _LazyStatusFormatter will only be called if the log is actually being printed, which saves computation time right?
There was a problem hiding this comment.
yes, we pass the object itself to the logger, and it only calls __str__ if the log level requires it.
vincbeck
requested changes
Jun 22, 2023
vincbeck
approved these changes
Jun 22, 2023
o-nikolas
approved these changes
Jun 22, 2023
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 27, 2023
Also changed the status formatting in the logs so that it'd not be done if log level is not including INFO
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also changed the status formatting in the logs so that it'd not be done if log level is not including INFO
cc @syedahsn