Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to GlueJobOperator to stop the job run when the TI is killed #32155

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

hussein-awala
Copy link
Member

closes: #32137

This PR adds a new boolean parameter stop_job_run_on_kill to GlueJobOperator, when it is set to True, the Glue job run will be stopped if the TI is killed (because of a timeout or a SIGTERM/clear).


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

…illed

Signed-off-by: Hussein Awala <hussein@awala.fr>
@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Jun 26, 2023
@hussein-awala hussein-awala added the type:new-feature Changelog: New Features label Jun 26, 2023
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple nit. I think glue_job can be confusing and can make you think you return the actual glue job

airflow/providers/amazon/aws/operators/glue.py Outdated Show resolved Hide resolved
@hussein-awala
Copy link
Member Author

@vincbeck @o-nikolas Thank you for your suggestion. Could you please take a second look?

@vincbeck vincbeck merged commit 1d60332 into apache:main Jun 28, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS - GlueJobOperator - stop job on task stop
3 participants