deprecate arbitrary parameter passing to RDS hook #32352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
Adaverse
reviewed
Jul 4, 2023
| warnings.warn( | ||
| "The parameter hook_params is deprecated and will be removed. " | ||
| "If you were using it, please get in touch either on airflow slack, " | ||
| "or by opening a github issue on the project. " |
There was a problem hiding this comment.
Very informative deprecation message. Just a small suggestion -
Suggested change
| "or by opening a github issue on the project. " | |
| "or by opening a Github issue on the project. " |
ferruzzi
approved these changes
Jul 4, 2023
vincbeck
approved these changes
Jul 4, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way RDS operators are built allows passing arbitrary parameters to the hook via a kwarg named
hook_params. However this is not documented anywhere, and the usefulness of the feature looks pretty dubious to me.We usually just let users pass the aws conn id and eventually the region, not anything they want.
I doubt anyone is using that, so I'm deprecating without any alternative ? If that's an OK thing to do ?