Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMR serverless Create/Start/Stop/Delete Application deferrable mode #32513

Merged

Conversation

syedahsn
Copy link
Contributor

This PR adds deferrable mode to EmrServerlessCreateApplicationOperator, EmrServerlessStopApplicationOperator, and EmrServerlessDeleteApplicationOperator. All the associated tests are included.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@syedahsn
Copy link
Contributor Author

@uranusjr @pragnareddye @vandonr-amz Can you please have another look at this PR? This is the same PR as #32414 - I ended up closing that because there was a problem with rebasing which messed up the commits 😅 This PR is the same one - I've addressed all comments. Please let me know if I've missed anything

@vandonr-amz
Copy link
Contributor

I left some comments on the previous PR that I don't think you addressed ? Maybe you can reply where I left them ?

airflow/providers/amazon/aws/hooks/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/hooks/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/emr.py Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/emr.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/triggers/emr.py Outdated Show resolved Hide resolved
@syedahsn syedahsn requested a review from Lee-W July 19, 2023 15:52
@syedahsn syedahsn force-pushed the syedahsn/deferrable-emr-serverless-create-appl branch from 230fdfc to 50d52d7 Compare July 21, 2023 07:00
@syedahsn syedahsn requested a review from Lee-W July 23, 2023 16:21
@o-nikolas o-nikolas merged commit 1706f05 into apache:main Jul 24, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants