BUGFIX: AWS ECS trigger returned "success" after max_attempts instead of failing #32589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of failing reported by user in issue apache#32580 the issue is about something else, but the user mentionned this as a "bonus bug"
boring-cyborg
bot
added
area:providers
provider:amazon-aws
eladkal
approved these changes
Jul 14, 2023
uranusjr
reviewed
Jul 14, 2023
| @@ -179,8 +181,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]: | |||
| finally: | |||
| if self.log_group and self.log_stream: | |||
| logs_token = await self._forward_logs(logs_client, logs_token) | |||
|
|
|||
| yield TriggerEvent({"status": "success", "task_arn": self.task_arn}) | |||
| raise AirflowException("Waiter error: max attempts reached") | |||
There was a problem hiding this comment.
This should yield a failure event instead
There was a problem hiding this comment.
I disagree, yielding an event will send this back to the scheduler, and require a worker to be setup and everything just to throw an error there. Might as well save all this by raising directly in the triggerer.
I was discussed quickly in this slack thread: https://apache-airflow.slack.com/archives/CCPRP7943/p1685663968275419
69 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported by user in issue #32580
the issue is about something else, but the user mentioned this as a "bonus bug"