-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX AWS deferrable operators by using AioCredentials when using assume_role
#32733
FIX AWS deferrable operators by using AioCredentials when using assume_role
#32733
Conversation
Fixes airflow.providers.amazong.aws.hooks.base_aws.BaseSessionFactory feeds synchronous credentials to aiobotocore when using `assume_role` apache#32732
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
@vandonr-amz @syedahsn and @vincbeck - can you please prioritize reviewing this? |
Could someone re-trigger the one failing check? It looks like there was a network hiccup when it was uploading the test results. |
Just did |
Would it be possible to add unit tests to cover when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching and fixing this !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for fixing it!
(I agree with @vincbeck about adding a unit test if possible)
@syedahsn @vincbeck Sure, I updated the existing tests for this method, which weren't checking if Alternatively, I could check if EDIT: Actually, since |
Interesting! LGTM. I'll merge it once the CI is green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
assume_role
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closes: #32732 airflow.providers.amazong.aws.hooks.base_aws.BaseSessionFactory feeds synchronous credentials to aiobotocore when using
assume_role