-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump azure-mgmt-containerinstance>=7.0.0,<9.0.0 #33696
Bump azure-mgmt-containerinstance>=7.0.0,<9.0.0 #33696
Conversation
No dice :( ... need some work I am afraid. |
Yeah, will investigate it and let see how it goes |
One of the issues is with
The parameter (type From official docs:
Thus bumping |
Thanks @eladkal I want |
in the 2nd option you won't need to deal with |
ce04108
to
de0ce51
Compare
de0ce51
to
5f2c6f3
Compare
Looks like at least tests are green @pankajastro :) |
35bdfa2
to
04f92b0
Compare
@pankajastro is it ready for review and merge? |
yes, just mark it ready for review. I have done with testing and worked |
Cooool.... One less thing to bump for Azure :). I am not sure if they deserve it, but well ... Who am I to judge. |
We still need to bump for >=9.0.0 and this means handling the issues I listed in #33696 (comment) |
Yes, I'll investigate it later this week |
I also updated #30199 |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.