Bump azure-mgmt-containerinstance #34738
Conversation
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
| @@ -90,7 +89,6 @@ class AzureContainerInstancesOperator(BaseOperator): | |||
| :param restart_policy: Restart policy for all containers within the container group. | |||
| Possible values include: 'Always', 'OnFailure', 'Never' | |||
| :param ip_address: The IP address type of the container group. | |||
| :param network_profile: The network profile information for a container group. | |||
There was a problem hiding this comment.
This is breaking change.
Please set major version on provider.yaml we will also need entry in changelog.rst (top of the file) with the things that were broken and how to mitigate them.
There was a problem hiding this comment.
yes, still try a few things, will update the provider.yaml and changelog.rst if needed
There was a problem hiding this comment.
yeah, updated provider.yaml and changelog
|
Hi, I'm just adding some additional info for you guys that will be relevant once you come to updating the hooks (related issue #34749)
|
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| import warnings | |||
| from functools import cached_property | |||
| from typing import TYPE_CHECKING, Any | |||
| from typing import TYPE_CHECKING, Any, cast | |||
|
|
|||
| from azure.common.client_factory import get_client_from_auth_file, get_client_from_json_dict | |||
| from azure.common.credentials import ServicePrincipalCredentials | |||
There was a problem hiding this comment.
Package is deprecated and no longer working. Consider using azure.identity (relevant info)
Related issue on azure-sdk-for-python
There was a problem hiding this comment.
Removed ServicePrincipalCredentials and added ClientSecretCredential from azure.identity
pankajastro
force-pushed
the
bump-azure-mgmt-containerinstance
branch
2 times, most recently
from
f35f605
to
39eb6e4
Compare
| @@ -52,7 +52,10 @@ def setup_test_cases(self, create_mock_connection): | |||
| conn_type="azure_container_instances", | |||
| login="login", | |||
| password="key", | |||
| extra={"tenantId": "tenant_id", "subscriptionId": "subscription_id"}, | |||
| extra={ | |||
| "tenantId": "63e85d06-62e4-11ee-8c99-0242ac120002", | |||
There was a problem hiding this comment.
Is it a valid id? or just some random one?
There was a problem hiding this comment.
it is Random. I use https://www.uuidgenerator.net/ to generate it. The new sdk throws a value error if tenantId is not valid uuid
|
|
||
| * Remove ``network_profile`` param from ``AzureContainerInstancesOperator`` | ||
| * Remove deprecated ``extra__azure__tenantId`` from azure_container_instance connection extras | ||
| * Remove deprecated ``extra__azure__subscriptionId`` from azure_container_instance connection extras |
There was a problem hiding this comment.
Should we mention the named tuple Volume has been removed as well?
There was a problem hiding this comment.
I have reverted this PTAL
pankajastro
force-pushed
the
bump-azure-mgmt-containerinstance
branch
from
39eb6e4
to
7f08469
Compare
pankajastro
force-pushed
the
bump-azure-mgmt-containerinstance
branch
from
7f08469
to
e3d6079
Compare
* Bump azure-mgmt-containerinstance * Apply review suggestions (cherry picked from commit 9ee14a0)
* Bump azure-mgmt-containerinstance * Apply review suggestions (cherry picked from commit 9ee14a0)
potiuk
added
the
type:misc/internal
Related to: #30199
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.