Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of cron-descriptor for custom TimeTables since BC in v1.3.0 #34836

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

poupounetjoyeux
Copy link
Contributor

When using a custom TimeTable that doesn't provide a CRON expression summary (e.g. : 'Custom TimeTable Plugin'), and if the web UI has not yet load the TimeTable when deserializing the DAG, accessing the grid view will try to parse the custom description as a CRON expression and then cron-descriptor, that introduce a breaking change in v1.3.0 that now calls 'parse' in the ctor of ExpressionDescriptor raise the FormatException outside of the try block

(working great in Airflow v2.4.2 that uses cron-descriptor v1.2.x)

C.f. : Salamek/cron-descriptor@ec9ea4d


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When using a custom TimeTable that doesn't provide a CRON expression summary (e.g. : 'Custom TimeTable Plugin'),
and if the web UI has not yet load the TimeTable when deserializing the DAG,
accessing the grid view will try to parse the custom description as a CRON expression and then cron-descriptor, that introduce a breaking change in v1.3.0 that now calls 'parse' in the ctor of ExpressionDescriptor raise the FormatException outside of the try block

(working great in Airflow v2.4.2 that uses cron-descriptor v1.2.x)

C.f. : Salamek/cron-descriptor@ec9ea4d
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 9, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal added this to the Airflow 2.7.3 milestone Oct 12, 2023
@eladkal eladkal added the type:bug-fix Changelog: Bug Fixes label Oct 12, 2023
@Taragolis Taragolis merged commit ec6d945 into apache:main Oct 19, 2023
43 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 19, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ephraimbuddy pushed a commit that referenced this pull request Oct 29, 2023
When using a custom TimeTable that doesn't provide a CRON expression summary (e.g. : 'Custom TimeTable Plugin'),
and if the web UI has not yet load the TimeTable when deserializing the DAG,
accessing the grid view will try to parse the custom description as a CRON expression and then cron-descriptor, that introduce a breaking change in v1.3.0 that now calls 'parse' in the ctor of ExpressionDescriptor raise the FormatException outside of the try block

(working great in Airflow v2.4.2 that uses cron-descriptor v1.2.x)

C.f. : Salamek/cron-descriptor@ec9ea4d

(cherry picked from commit ec6d945)
ephraimbuddy pushed a commit that referenced this pull request Oct 30, 2023
When using a custom TimeTable that doesn't provide a CRON expression summary (e.g. : 'Custom TimeTable Plugin'),
and if the web UI has not yet load the TimeTable when deserializing the DAG,
accessing the grid view will try to parse the custom description as a CRON expression and then cron-descriptor, that introduce a breaking change in v1.3.0 that now calls 'parse' in the ctor of ExpressionDescriptor raise the FormatException outside of the try block

(working great in Airflow v2.4.2 that uses cron-descriptor v1.2.x)

C.f. : Salamek/cron-descriptor@ec9ea4d

(cherry picked from commit ec6d945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants