Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe workaround to packaging 23.2 breaking pipx local detection #35092

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 20, 2023

The latest packaging - 23.2 breaks pipx detection of local path installation and renders breeze installation impossible. The workaround to it until pypa/pipx#1092 is solved is to downgrade packaging to < 23.2 - this is mostly applicable to fresh installations of pipx that pull the latest packaging.

This PR adds appropriate description to breeze installation process

  • what to do when it fails, it also updates the advice printed when the fallback to non-editable installation and provide an advice to downgrade packaging.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The latest packaging - 23.2 breaks `pipx` detection of local path
installation and renders breeze installation impossible. The
workaround to it until pypa/pipx#1092
is solved is to downgrade packaging to < 23.2 - this is mostly
applicable to fresh installations of `pipx` that pull the latest
packaging.

This PR adds appropriate description to breeze installation process
- what to do when it fails, it also updates the advice printed
when the fallback to non-editable installation and provide an
advice to downgrade packaging.
@potiuk potiuk force-pushed the add-workaround-for-pipx-packaging-broken-editable-installs branch from d5d5c8a to bc722df Compare October 20, 2023 21:34
@potiuk potiuk merged commit 4e460bf into apache:main Oct 20, 2023
57 of 59 checks passed
@potiuk potiuk deleted the add-workaround-for-pipx-packaging-broken-editable-installs branch October 20, 2023 22:07
@ephraimbuddy ephraimbuddy added this to the Airflow 2.7.3 milestone Oct 27, 2023
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Oct 27, 2023
potiuk added a commit that referenced this pull request Oct 29, 2023
…35092)

The latest packaging - 23.2 breaks `pipx` detection of local path
installation and renders breeze installation impossible. The
workaround to it until pypa/pipx#1092
is solved is to downgrade packaging to < 23.2 - this is mostly
applicable to fresh installations of `pipx` that pull the latest
packaging.

This PR adds appropriate description to breeze installation process
- what to do when it fails, it also updates the advice printed
when the fallback to non-editable installation and provide an
advice to downgrade packaging.

(cherry picked from commit 4e460bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants