Add pytest db_test markers to our tests #35264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is separated out from apache#35160 in order to make the big refactor and splitting out our test harness to DB and Non-DB tests far more easy to review. This change contains purely adding db_tests markers to the tests that need them, and as such it requires very litte effort to review. Once this one is merged hoever, the apache#35160 will become way smaller in terms of number of files to review, which will make it far easier to review using GitHub Interface.
potiuk
requested review from
dstandish,
hussein-awala,
pankajastro,
uranusjr,
jscheffl and
vincbeck
|
This one should ONLY contain adding db_test markers, so it should be super-easy to review even locally with |
|
This one should be NO-OP for the current code - i.e. the db_test markers are added but do nothing. |
utkarsharma2
approved these changes
Oct 30, 2023
Lee-W
approved these changes
Oct 30, 2023
|
Would love to merge it to make #35160 look reviewable (and on a good path to get back with stability and improve speed of the CI overall) :D |
potiuk
requested review from
Taragolis,
ephraimbuddy,
pankajkoti,
pierrejeambrun and
phanikumv
|
BTW. The easiest way to review it is to do |
|
My magic script to review that one in a few seconds: git diff HEAD^ | grep '^[+-][^+-]' | grep -v "import pytest" | grep -v "pytest.mark.db_test" |
vincbeck
approved these changes
Oct 30, 2023
jscheffl
approved these changes
Oct 30, 2023
potiuk
added
the
type:misc/internal
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 1, 2023
This PR is separated out from #35160 in order to make the big refactor and splitting out our test harness to DB and Non-DB tests far more easy to review. This change contains purely adding db_tests markers to the tests that need them, and as such it requires very litte effort to review. Once this one is merged hoever, the #35160 will become way smaller in terms of number of files to review, which will make it far easier to review using GitHub Interface. (cherry picked from commit 1aa91a4)
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is separated out from #35160 in order to make the big refactor and splitting out our test harness to DB and Non-DB tests far more easy to review.
This change contains purely adding db_tests markers to the tests that need them, and as such it requires very litte effort to review. Once this one is merged hoever, the #35160 will become way smaller in terms of number of files to review, which will make it far easier to review using GitHub Interface.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.