-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more ways to connect to weaviate #35864
Merged
ephraimbuddy
merged 5 commits into
apache:main
from
astronomer:improve-weaviate-connection
Nov 28, 2023
Merged
Add more ways to connect to weaviate #35864
ephraimbuddy
merged 5 commits into
apache:main
from
astronomer:improve-weaviate-connection
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ephraimbuddy It looks good to me, can we also update the relevant docs? - https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-weaviate/connections.rst |
ephraimbuddy
force-pushed
the
improve-weaviate-connection
branch
3 times, most recently
from
November 28, 2023 12:27
294a0d8
to
17d8d90
Compare
There are other options for connecting to weaviate. This commit adds these other options and also improved the imports/typing
ephraimbuddy
force-pushed
the
improve-weaviate-connection
branch
from
November 28, 2023 13:25
302bdbf
to
45037e8
Compare
utkarsharma2
approved these changes
Nov 28, 2023
phanikumv
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ephraimbuddy
commented
Nov 28, 2023
ephraimbuddy
force-pushed
the
improve-weaviate-connection
branch
from
November 28, 2023 17:26
0460871
to
1f12b0a
Compare
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are other options for connecting to weaviate. This commit adds these other options and also improved the imports/typing