Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ways to connect to weaviate #35864

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

ephraimbuddy
Copy link
Contributor

There are other options for connecting to weaviate. This commit adds these other options and also improved the imports/typing

@utkarsharma2
Copy link
Contributor

@ephraimbuddy It looks good to me, can we also update the relevant docs? - https://github.com/apache/airflow/blob/main/docs/apache-airflow-providers-weaviate/connections.rst

@ephraimbuddy ephraimbuddy force-pushed the improve-weaviate-connection branch 3 times, most recently from 294a0d8 to 17d8d90 Compare November 28, 2023 12:27
There are other options for connecting to weaviate. This commit adds
these other options and also improved the imports/typing
@ephraimbuddy ephraimbuddy force-pushed the improve-weaviate-connection branch from 302bdbf to 45037e8 Compare November 28, 2023 13:25
Copy link
Contributor

@phanikumv phanikumv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ephraimbuddy ephraimbuddy force-pushed the improve-weaviate-connection branch from 0460871 to 1f12b0a Compare November 28, 2023 17:26
@ephraimbuddy ephraimbuddy merged commit 2919abe into apache:main Nov 28, 2023
47 checks passed
@ephraimbuddy ephraimbuddy deleted the improve-weaviate-connection branch November 28, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants