-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to build "chicken-egg" packages from sources #35890
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
build-common-io-from-sources
branch
from
November 27, 2023 15:01
11d7aa3
to
c7ef746
Compare
potiuk
force-pushed
the
build-common-io-from-sources
branch
from
November 27, 2023 15:22
c7ef746
to
46f304d
Compare
potiuk
force-pushed
the
build-common-io-from-sources
branch
6 times, most recently
from
November 28, 2023 22:09
8ee145c
to
be7b6f7
Compare
eladkal
approved these changes
Nov 28, 2023
potiuk
force-pushed
the
build-common-io-from-sources
branch
4 times, most recently
from
November 29, 2023 02:45
2b8b5f0
to
583d186
Compare
potiuk
force-pushed
the
build-common-io-from-sources
branch
from
November 29, 2023 03:49
583d186
to
9ee1133
Compare
potiuk
force-pushed
the
build-common-io-from-sources
branch
from
November 29, 2023 03:53
9ee1133
to
e53bb0d
Compare
When we build on ci a pre-release version of provider, and we want to include packages that have >= CURRENTLY_RELEASED_VERSION we have to make sure that those packages are built from sources during building of PROD image. Otherwise they will not be installable on CURRENT_VERSION.dev0, CURRENT_VERSION.rc* etc. Until we "Actually" release a provider we should have a way to build such provider from sources. This is the CI version of it, once we have it working we can also apply it to the workflow that releases images to dockerhub.
potiuk
force-pushed
the
build-common-io-from-sources
branch
from
November 29, 2023 23:30
e53bb0d
to
acec7a4
Compare
ephraimbuddy
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Dec 5, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 5, 2023
When we build on ci a pre-release version of provider, and we want to include packages that have >= CURRENTLY_RELEASED_VERSION we have to make sure that those packages are built from sources during building of PROD image. Otherwise they will not be installable on CURRENT_VERSION.dev0, CURRENT_VERSION.rc* etc. Until we "Actually" release a provider we should have a way to build such provider from sources. This is the CI version of it, once we have it working we can also apply it to the workflow that releases images to dockerhub. (cherry picked from commit cf052dc)
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:dev-tools
area:providers
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we build on ci a pre-release version of provider, and we want to include packages that have >= CURRENTLY_RELEASED_VERSION we have to make sure that those packages are built from sources during building of PROD image. Otherwise they will not be installable on CURRENT_VERSION.dev0, CURRENT_VERSION.rc* etc.
Until we "Actually" release a provider we should have a way to build such provider from sources.
This is the CI version of it, once we have it working we can also apply it to the workflow that releases images to dockerhub.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.