Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to build "chicken-egg" packages from sources #35890

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Nov 27, 2023

When we build on ci a pre-release version of provider, and we want to include packages that have >= CURRENTLY_RELEASED_VERSION we have to make sure that those packages are built from sources during building of PROD image. Otherwise they will not be installable on CURRENT_VERSION.dev0, CURRENT_VERSION.rc* etc.

Until we "Actually" release a provider we should have a way to build such provider from sources.

This is the CI version of it, once we have it working we can also apply it to the workflow that releases images to dockerhub.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk marked this pull request as draft November 27, 2023 14:59
@potiuk potiuk force-pushed the build-common-io-from-sources branch from 11d7aa3 to c7ef746 Compare November 27, 2023 15:01
@potiuk potiuk changed the base branch from v2-8-test to v2-8-stable November 27, 2023 15:07
@potiuk potiuk closed this Nov 27, 2023
@potiuk potiuk reopened this Nov 27, 2023
@potiuk potiuk changed the base branch from v2-8-stable to main November 27, 2023 15:09
@potiuk potiuk closed this Nov 27, 2023
@potiuk potiuk reopened this Nov 27, 2023
@potiuk potiuk force-pushed the build-common-io-from-sources branch from c7ef746 to 46f304d Compare November 27, 2023 15:22
@potiuk potiuk marked this pull request as ready for review November 27, 2023 15:50
@potiuk potiuk added this to the Airflow 2.8.0 milestone Nov 27, 2023
@potiuk potiuk force-pushed the build-common-io-from-sources branch 6 times, most recently from 8ee145c to be7b6f7 Compare November 28, 2023 22:09
@potiuk potiuk force-pushed the build-common-io-from-sources branch 4 times, most recently from 2b8b5f0 to 583d186 Compare November 29, 2023 02:45
@potiuk potiuk force-pushed the build-common-io-from-sources branch from 583d186 to 9ee1133 Compare November 29, 2023 03:49
@potiuk potiuk requested a review from o-nikolas as a code owner November 29, 2023 03:49
@potiuk potiuk force-pushed the build-common-io-from-sources branch from 9ee1133 to e53bb0d Compare November 29, 2023 03:53
When we build on ci a pre-release version of provider, and we want
to include packages that have >= CURRENTLY_RELEASED_VERSION
we have to make sure that those packages are built from sources
during building of PROD image. Otherwise they will not be installable
on CURRENT_VERSION.dev0, CURRENT_VERSION.rc* etc.

Until we "Actually" release a provider we should have a way to
build such provider from sources.

This is the CI version of it, once we have it working we can also
apply it to the workflow that releases images to dockerhub.
@potiuk potiuk force-pushed the build-common-io-from-sources branch from e53bb0d to acec7a4 Compare November 29, 2023 23:30
@potiuk potiuk merged commit cf052dc into main Dec 1, 2023
70 of 73 checks passed
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Dec 5, 2023
ephraimbuddy pushed a commit that referenced this pull request Dec 5, 2023
When we build on ci a pre-release version of provider, and we want
to include packages that have >= CURRENTLY_RELEASED_VERSION
we have to make sure that those packages are built from sources
during building of PROD image. Otherwise they will not be installable
on CURRENT_VERSION.dev0, CURRENT_VERSION.rc* etc.

Until we "Actually" release a provider we should have a way to
build such provider from sources.

This is the CI version of it, once we have it working we can also
apply it to the workflow that releases images to dockerhub.

(cherry picked from commit cf052dc)
@Taragolis Taragolis deleted the build-common-io-from-sources branch December 27, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants