Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use S3 hook instead of AwsGenericHook in AWS S3 FS #35973

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Use S3 hook instead of AwsGenericHook in AWS S3 FS #35973

merged 1 commit into from
Nov 30, 2023

Conversation

hussein-awala
Copy link
Member

Replace AwsGenericHook(..., client_type="s3") with S3Hook(...), which does the same thing implicitly in the AWS S3 FS.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Nov 30, 2023
bolkedebruin
bolkedebruin approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@bolkedebruin bolkedebruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough ;-)

@bolkedebruin bolkedebruin merged commit df36e73 into apache:main Nov 30, 2023
47 checks passed
@eladkal eladkal mentioned this pull request Dec 7, 2023
Closed
50 tasks
ephraimbuddy pushed a commit that referenced this pull request Dec 11, 2023
@hussein-awala @ephraimbuddy
Use S3 hook instead of AwsGenericHook in AWS S3 FS (#35973)
bdadabc 
(cherry picked from commit df36e73)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolkedebruin bolkedebruin bolkedebruin approved these changes

@eladkal eladkal Awaiting requested review from eladkal

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

Assignees
No one assigned
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussein-awala @bolkedebruin