Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refacto CloudwatchTaskHandler set_context method #35975

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Refacto CloudwatchTaskHandler set_context method #35975

merged 1 commit into from
Nov 30, 2023

Conversation

hussein-awala
Copy link
Member

Update set_context method signature to match superclass one, and stop setting the instance attribute json_serialize which doesn't exist.

@vincbeck vincbeck merged commit ddb4370 into apache:main Nov 30, 2023
47 checks passed
@eladkal eladkal mentioned this pull request Dec 7, 2023
Closed
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincbeck vincbeck vincbeck approved these changes

@eladkal eladkal Awaiting requested review from eladkal

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

Assignees
No one assigned
Labels
area:logging area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussein-awala @vincbeck