Add a cache for weaviate client #35983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajkoti
approved these changes
Dec 1, 2023
Lee-W
reviewed
Dec 1, 2023
utkarsharma2
approved these changes
Dec 1, 2023
| AirflowProviderDeprecationWarning, | ||
| stacklevel=2, | ||
| ) | ||
| """Returns a Weaviate client.""" | ||
| return self.get_conn() |
There was a problem hiding this comment.
Instead of removing the deprecation warning from this method, you can make get_conn a cached property and change this method to:
Suggested change
| return self.get_conn() | |
| return self.get_conn |
In that way, you will achieve what you want to do without replacing self.get_client() with self.get_client, and this method will stay deprecated.
There was a problem hiding this comment.
I don't think having the cache on get_conn is a good one but I agree to keep the deprecation. It would be better to have another method like _weaviate_client or conn like @Lee-W suggested. It means more options for users and doing hook.get_conn would be just a statement that IDEs may not fancy.
While working on another issue, I realized how often I had to call get_conn. So instead of depreccating this, we can use it as a cache within the code so we don't connect everytime a method is called.
ephraimbuddy
force-pushed
the
add-cache-for-client
branch
from
ca854e3 to
65c2798
Compare
ephraimbuddy
force-pushed
the
add-cache-for-client
branch
from
65c2798 to
14b8a2d
Compare
hussein-awala
approved these changes
Dec 1, 2023
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another issue, I realized how often I had to call get_conn. So instead of depreccating this, we can use it as a cache within the code so we don't connect everytime a method is called.