Repair different run_id for OpenLineage START and FAIL events. #36051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with OpenLineage FAIL event having different run_id than START event. This fixes the issue and add tests to prevent it from happening in the future.
The issue was that we decreased try_number in
on_task_instance_failed
as we wanted it to be the same as inon_task_instance_running
(try_number is used to generate deterministic run_id). As it turned out, whenon_task_instance_failed
is called, the try_number is not yet automatically increased by Airflow, so we do not have to do that - it just need to be done inon_task_instance_success
.If You want to reproduce the issue run the below dag with OpenLineage integration, You should receive different run_id in START and FAIL event.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.