GCP Secrets Backend Impersonation #36072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:secrets
kind:documentation
provider:google
nathadfield
force-pushed
the
feat/secrets_backend_impersonation
branch
from
ec623e6 to
c9b2614
Compare
potiuk
approved these changes
Dec 5, 2023
|
Chance for a unit test? |
@potiuk I guess I initially thought that the tests were covered as part of the |
|
Merged it anyway,. But if you can add some tests - would be cool :) |
50 tasks
19 tasks
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for service account impersonation via
backend_kwargswhen using the GCP Secrets Backend.