Add retry mechanism and dataframe support for WeaviateIngestOperator #36085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Dec 6, 2023
uranusjr
reviewed
Dec 6, 2023
uranusjr
reviewed
Dec 6, 2023
utkarsharma2
commented
Dec 6, 2023
utkarsharma2
requested review from
ephraimbuddy,
sunank200,
pankajkoti,
pankajastro,
uranusjr and
phanikumv
pankajkoti
reviewed
Dec 6, 2023
utkarsharma2
commented
Dec 6, 2023
uranusjr
reviewed
Dec 7, 2023
utkarsharma2
requested review from
potiuk,
ashb and
pierrejeambrun
as code owners
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
By moving the check to before the self.input_data assignment, we can hint to the checker that this attribute is never None.
utkarsharma2
force-pushed
the
retry_batch_data
branch
from
1abda63 to
81d62f3
Compare
ephraimbuddy
approved these changes
Dec 7, 2023
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR add the retry mechanism while ingesting data into Weaviate, this is needed to ensure the data that we intend to ingest is not affected by the possible network or ratelimiting issue. We also extend the support for ingestion data format to include pandas dataframe.