Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides to template fields of Google Cloud Run Jobs Execute Operator #36133

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

guillaumeblaquiere
Copy link
Contributor

Close #36132


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Dec 9, 2023
Copy link

boring-cyborg bot commented Dec 9, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal changed the title Feature 36132: add overrides in the template fields of Google Cloud Run Jobs Execute Operator Add overrides to template fields of Google Cloud Run Jobs Execute Operator Dec 9, 2023
@guillaumeblaquiere
Copy link
Contributor Author

guillaumeblaquiere commented Dec 11, 2023

@potiuk some checks fail because of static files. I haven't changed anything on that part. Does this block the merge?

@potiuk
Copy link
Member

potiuk commented Dec 11, 2023

Nope. I fixed it already earlier today in #36162

@potiuk potiuk merged commit 3dddfb4 into apache:main Dec 11, 2023
49 of 50 checks passed
Copy link

boring-cyborg bot commented Dec 11, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add overrides in the template field for the Google Cloud Run Jobs Execute operator
2 participants