Change retry type for Google Clients to async ones where needed #36141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
eladkal
approved these changes
Dec 9, 2023
|
Needs few more libraries and more complete/selective use of AsyncRetry - seems the fixes were applied to a number of Google clients. |
potiuk
force-pushed
the
fix-retry-parameter-type-dataproc
branch
from
c12c8c6 to
a43fbba
Compare
|
Right .. That one should be green (and I believe good for RC2 of google provider). |
potiuk
changed the title
potiuk
changed the title
potiuk
force-pushed
the
fix-retry-parameter-type-dataproc
branch
from
a43fbba to
0d0a25a
Compare
|
OK. I found one more edge case in the new "provider verification" a fix to that will follow - then we will be able to merge it when It is merged. The problem is that if we bump a provider version and current constraints do not have it, we will not be able to install those new providers with old constraints. But there is a way to fix it. |
|
Fix in #36143 |
potiuk
force-pushed
the
fix-retry-parameter-type-dataproc
branch
from
0d0a25a to
e446d75
Compare
Google Dataflow Client 0.8.6 implemented bugfix where retry type was changed to async. This caused our canary builds to fail. We change the client to Async now and bump min version of the client to 0.8.6.
potiuk
force-pushed
the
fix-retry-parameter-type-dataproc
branch
from
e446d75 to
6c24a9f
Compare
|
The fix worked :). and even had a follow-up. Merging it. |
19 tasks
potiuk
added a commit
that referenced
this pull request
Dec 15, 2023
Google Dataflow Client 0.8.6 implemented bugfix where retry type was changed to async. This caused our canary builds to fail. We change the client to Async now and bump min version of the client to 0.8.6. (cherry picked from commit 8d0c5d9)
ephraimbuddy
added
the
changelog:skip
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Dataflow Clientss, implemented bugfixes where retry type was changed to async where async was used:
This caused our canary builds to fail.
We changed all the places where retry is Async now and bumped min version of the clients:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.