iterate through blobs before checking prefixes #36202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
Lee-W
force-pushed
the
fix-gcs-hook-blob-iterator-consuming
branch
from
ef32ffd to
f5899d8
Compare
atrbgithub
reviewed
Dec 13, 2023
Lee-W
force-pushed
the
fix-gcs-hook-blob-iterator-consuming
branch
from
f5899d8 to
5a53d2e
Compare
19 tasks
|
This PR will potentially fix the error on the google provider rc. Could you kindly include it in the next rc for google provider. cc @potiuk |
|
This test https://github.com/apache/airflow/pull/36202/files#diff-76fef248bc8b2046dae5e6e1fe60dcb916e4114d85190c563454d2d123937b43R829 mainly checks the prefixes is actually used if exist https://github.com/apache/airflow/pull/36202/files#diff-82854006b5553665046db26d43a9dfa90bec78d4ba93e2d2ca7ff5bf632fa624R944-R945. |
potiuk
approved these changes
Dec 13, 2023
pankajastro
approved these changes
Dec 13, 2023
Lee-W
force-pushed
the
fix-gcs-hook-blob-iterator-consuming
branch
from
40b22ed to
1ea2c4c
Compare
hussein-awala
approved these changes
Dec 13, 2023
According to https://github.com/googleapis/python-storage/blob/v2.14.0/google/cloud/storage/client.py#L1213-L1217, the prefixes are not returned until the blobs are consumed
Lee-W
force-pushed
the
fix-gcs-hook-blob-iterator-consuming
branch
from
1ea2c4c to
0e77b7e
Compare
Lee-W
force-pushed
the
fix-gcs-hook-blob-iterator-consuming
branch
from
0e77b7e to
8fe8f77
Compare
|
Just in time for RC3 |
|
Looks great! Thanks :) |
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading https://cloud.google.com/storage/docs/json_api/v1/objects/list, https://github.com/googleapis/python-storage/blob/v2.14.0/google/cloud/storage/client.py#L1143-L1145C35 and https://github.com/apache/airflow/blob/providers-google/10.13.0rc2/airflow/providers/google/cloud/hooks/gcs.py#L732, I suspect we might not use the
delimiterthe right way. But it's going to be deprecated. So it might be better for us to keep the original behavior.According to https://github.com/googleapis/python-storage/blob/v2.14.0/google/cloud/storage/client.py#L1213-L1217, the prefixes are not returned until the
blobsare consumed. Thus, to keep the behavior of checking whetherprefixesexists and decide the extended content, we'll need to consumeblobsfirstRelated: #36130
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.