-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add param proxy user for hive #36221
Conversation
26eac1c
to
2a25768
Compare
483a317
to
9c83bfe
Compare
Hmm. Isn't it the same as (undocumented in the docstring) |
I see it's NOT the same... But I also have. feeling this is a bit cryptic now : when extra_dejson = param => choose proxy user, when owner -> choos run_as. Shoudl we document it better at the very least :) ? Or maybe it's already documented somwhere? |
9c83bfe
to
c2305d6
Compare
I added a better documentation. |
c2305d6
to
b03716c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Agree this is a nice thing to add and follow-up with making thigs simpler should come next.
Know there are three options to add proxy user to hive cli connection: by dag owner, by connection logging or by custom proxy (as extra in the connection).
This PR add a fourth option param proxy user. by setting
proxy_user=param
in connection allow us to pass the user in HiveOperator.I think this PR is needed from some option:
Added an option to sent proxy_param in HiveOperator when allow it in the connection.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.