-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sentinel_kwargs
load from ENV
#36318
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can fix the issue with this small change:
- sentinel_kwargs = broker_transport_options.get("sentinel_kwargs")
+ sentinel_kwargs = json.loads(broker_transport_options.get("sentinel_kwargs"))
Also you need to add a new test for this change.
Added test to check that config is loaded from a string. |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Celery provider is expecting
sentinel_kwargs
to be adict
, current implementation is only working when config is set throughairflow.cfg
.When the env variable
AIRFLOW__CELERY_BROKER_TRANSPORT_OPTIONS__SENTINEL_KWARGS
is set, it loads it as a string and thus fails. This pull request fixes this issue and bothairflow.cfg
and env variable will work. (Also removed additional copy ofbroker_transport_options
dict since it serves no purpose)Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.