Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions of parent folders for log file handler #37310

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Feb 10, 2024

When we created a new folder during log file handler directory creation we did not change the permissions of parent folders.

Fixes: #37200


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When we created a new folder during log file handler directory creation
we did not change the permissions of parent folders.

Fixes: apache#37200
@potiuk potiuk merged commit aae4a83 into apache:main Feb 10, 2024
56 checks passed
@potiuk potiuk deleted the change_folder_permissions_also_for_parents branch February 10, 2024 19:46
@ephraimbuddy ephraimbuddy added this to the Airflow 2.8.2 milestone Feb 19, 2024
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Feb 19, 2024
ephraimbuddy pushed a commit that referenced this pull request Feb 20, 2024
When we created a new folder during log file handler directory creation
we did not change the permissions of parent folders.

Fixes: #37200
(cherry picked from commit aae4a83)
ephraimbuddy pushed a commit that referenced this pull request Feb 22, 2024
When we created a new folder during log file handler directory creation
we did not change the permissions of parent folders.

Fixes: #37200
(cherry picked from commit aae4a83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logging type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permissions of new log directory not being set to parent folders.
3 participants