-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PY* constants into the airflow module #37575
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:core-operators
Operators, Sensors and hooks within Core Airflow
area:providers
area:serialization
provider:apache-hive
labels
Feb 20, 2024
Taragolis
added
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Feb 20, 2024
I do not delete this constants for two reason:
|
Taragolis
commented
Feb 20, 2024
hussein-awala
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Taragolis
removed
the
changelog:skip
Changes that should be skipped from the changelog (CI, tests, etc..)
label
Feb 21, 2024
dirrao
approved these changes
Feb 21, 2024
Dev-iL
reviewed
Feb 21, 2024
Taragolis
force-pushed
the
deprecate-py-constants
branch
from
February 21, 2024 13:55
46b976e
to
1494c47
Compare
Taragolis
force-pushed
the
deprecate-py-constants
branch
from
February 21, 2024 16:08
1494c47
to
584347d
Compare
potiuk
approved these changes
Feb 21, 2024
ephraimbuddy
added
the
type:misc/internal
Changelog: Misc changes that should appear in change log
label
Mar 6, 2024
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 31, 2024
These were deprecated in 2.9 by apache#37575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:core-operators
Operators, Sensors and hooks within Core Airflow
area:providers
area:serialization
provider:apache-hive
type:misc/internal
Changelog: Misc changes that should appear in change log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First constant was added in #7517 for validate is Airflow run on Python >= 3.7 and if not use backport support of PEP-562.
It is not widely use in Airflow Core, at that moment there is only one reference. However it might be not safe to use it in core, because it might create cyclic error in case if it imported somewhere else during first load, e.g. into the
airflow.configurations
orairflow.settings
or their imports. In providers it is not practical to use it, you have to wait approx one year for allow to use it, and it also might be a reason for cyclic errors, e.g. if it use in secrets backends and their imports.For avoid usage in project it disabled by
TID251
- Banned APIAll current usage, most in tests, replaced by
sys.version_info
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.