-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openlineage: add opt-in
option
#37725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
kind:documentation
provider:openlineage
AIP-53
labels
Feb 26, 2024
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
February 26, 2024 22:39
242c9ef
to
86d8b5e
Compare
mobuchowski
reviewed
Feb 27, 2024
uranusjr
reviewed
Feb 27, 2024
JDarDagran
force-pushed
the
openlineage/opt-in
branch
2 times, most recently
from
March 8, 2024 14:06
aa139e6
to
6472b9f
Compare
mobuchowski
reviewed
Mar 8, 2024
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
March 11, 2024 11:11
6472b9f
to
fde66c9
Compare
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
March 11, 2024 14:28
fde66c9
to
bd81eef
Compare
tatiana
reviewed
Mar 21, 2024
tatiana
reviewed
Mar 21, 2024
tatiana
reviewed
Mar 21, 2024
tatiana
reviewed
Mar 21, 2024
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
March 22, 2024 12:04
bd81eef
to
b5ba591
Compare
kacpermuda
reviewed
Mar 25, 2024
kacpermuda
reviewed
Mar 25, 2024
mobuchowski
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just address one @kacpermuda comment before merging.
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
March 25, 2024 22:31
b5ba591
to
e988501
Compare
uranusjr
reviewed
Mar 26, 2024
uranusjr
reviewed
Mar 26, 2024
by default and enable it selectively. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
March 26, 2024 09:53
e988501
to
1a5d79e
Compare
kacpermuda
reviewed
Mar 26, 2024
uranusjr
approved these changes
Mar 26, 2024
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
JDarDagran
force-pushed
the
openlineage/opt-in
branch
from
March 26, 2024 10:23
1a5d79e
to
e0a08d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
Currently you can only disable OpenLineage for all DAGs and tasks or selectively disable by operator class. Users report lack of possibility to do so on DAG/task level instead while opting in.
Proposed solution
Add
opt_in
option as well asenable/disable_lineage
methods that work both on DAG and task objects.Internally it passes constant parameter (Airflow's
airflow.models.Param
) that is next checked in OpenLineage listener.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.