Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruff to 0.3.3 #38240

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Bump ruff to 0.3.3 #38240

merged 1 commit into from
Mar 18, 2024

Conversation

hussein-awala
Copy link
Member

Most of the changes are related to astral-sh/ruff#8283 which adds a newline after module docstrings.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of empty line changes, but changing it just before 2.9 is a good idea - one of the tests is failing though.

@Taragolis
Copy link
Contributor

Sooner of later we have to bump ruff, this change required to rebase some of the current open PRs but shouldn't be consider as show stopper.

It might be also a good idea to add in follow up PR revision of the commit to the .git-blame-ignore-revs

@hussein-awala hussein-awala added this to the Airflow 2.9.0 milestone Mar 18, 2024
@hussein-awala hussein-awala added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 18, 2024
@hussein-awala hussein-awala merged commit 0a74928 into apache:main Mar 18, 2024
86 of 88 checks passed
hussein-awala added a commit to hussein-awala/airflow that referenced this pull request Mar 18, 2024
hussein-awala added a commit that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API area:CLI area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants