-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for role arn for aws creds in storage transfer job operators #38911
Add support for role arn for aws creds in storage transfer job operators #38911
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
@Taragolis apologies if this is not the correct way to do this but tagging you since you looked at #35292 previously. |
@Taragolis - pinging again following the directions of "be persistent". Again, apologies if this is not the correct procedure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know google provider very well so there may be something I'm missing, but the code LGTM. If those unit tests are passing and the CI goes green, I think it's good to merge.
Thanks @ferruzzi! |
@wlinamchurch You still need one more approval, perhaps drop a message in the slack #contributors channel asking for another set of eyes. |
Thanks @Taragolis! |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Congrats! Thanks for your contribution and your patience! |
closes: #35271
related: Attempt to fix tests and checks from #35292
This PR adds support to use role arn's for AWS credentials in storage transfer jobs. All of the substantive code changes were made in #35292.
My additional contributions were to get the tests to pass and pre-commit checks to pass.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.