Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for role arn for aws creds in storage transfer job operators #38911

Merged
merged 1 commit into from
May 1, 2024
Merged

Add support for role arn for aws creds in storage transfer job operators #38911

merged 1 commit into from
May 1, 2024

Conversation

wlinamchurch
Copy link
Contributor

closes: #35271
related: Attempt to fix tests and checks from #35292

This PR adds support to use role arn's for AWS credentials in storage transfer jobs. All of the substantive code changes were made in #35292.

My additional contributions were to get the tests to pass and pre-commit checks to pass.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 10, 2024
Copy link

boring-cyborg bot commented Apr 10, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@wlinamchurch
Copy link
Contributor Author

@Taragolis apologies if this is not the correct way to do this but tagging you since you looked at #35292 previously.

@wlinamchurch
Copy link
Contributor Author

@Taragolis - pinging again following the directions of "be persistent". Again, apologies if this is not the correct procedure.

@eladkal eladkal requested review from ferruzzi and vincbeck April 25, 2024 20:39
Copy link
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know google provider very well so there may be something I'm missing, but the code LGTM. If those unit tests are passing and the CI goes green, I think it's good to merge.

@wlinamchurch
Copy link
Contributor Author

Thanks @ferruzzi!

@ferruzzi
Copy link
Contributor

@wlinamchurch You still need one more approval, perhaps drop a message in the slack #contributors channel asking for another set of eyes.

@wlinamchurch
Copy link
Contributor Author

Thanks @Taragolis!

@ferruzzi ferruzzi merged commit e3e6aa9 into apache:main May 1, 2024
40 checks passed
Copy link

boring-cyborg bot commented May 1, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ferruzzi
Copy link
Contributor

ferruzzi commented May 1, 2024

Congrats! Thanks for your contribution and your patience!

@wlinamchurch wlinamchurch deleted the linam/lalmgren_enable_using_wif_for_storage_transfer_squash branch May 1, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudDataTransferServiceS3ToGCSOperator does not support identify federation
3 participants