Mark WASB blob tests as DB tests #38963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WASB blob tests started to fail intermittently after retries were implemented in apache#38910. Without understanding all the details, it seems that the async tests run in xdist mode of tests suffer from the bug of pytest-xdist - because the thread that runs some of the tests is not main and it likely interferes with signals handling and is likely an incarnation of pytest-dev/pytest-xdist#620 (which still needs to be solved in pytest-xdist) Since those two tests that keeps on failing intermittently and the other tests have been marked as db_test - likely for the same reason, we should simply mark all the module as db_test to avoid the interference.
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
|
cc: @dabla |
pankajkoti
approved these changes
Apr 12, 2024
|
Looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASB blob tests started to fail intermittently after retries were implemented in #38910. Without understanding all the details, it seems that the async tests run in xdist mode of tests suffer from the bug of pytest-xdist - because the thread that runs some of the tests is not main and it likely interferes with signals handling and is likely an incarnation of
pytest-dev/pytest-xdist#620 (which still needs to be solved in pytest-xdist)
Since those two tests that keeps on failing intermittently and the other tests have been marked as db_test - likely for the same reason, we should simply mark all the module as db_test to avoid the interference.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.