Add job_id parameter to BigQueryGetDataOperator
#39315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
shahar1
force-pushed
the
bigquery-get-data-job-id
branch
4 times, most recently
from
8b1475b to
6bd4169
Compare
Lee-W
reviewed
Apr 30, 2024
shahar1
force-pushed
the
bigquery-get-data-job-id
branch
from
6bd4169 to
8c99df2
Compare
shahar1
force-pushed
the
bigquery-get-data-job-id
branch
from
8c99df2 to
d2c2dff
Compare
Lee-W
reviewed
May 1, 2024
shahar1
force-pushed
the
bigquery-get-data-job-id
branch
from
d2c2dff to
7fd870f
Compare
shahar1
force-pushed
the
bigquery-get-data-job-id
branch
from
7fd870f to
9013fe0
Compare
shahar1
force-pushed
the
bigquery-get-data-job-id
branch
from
9013fe0 to
db1c476
Compare
eladkal
approved these changes
May 2, 2024
|
I'm thinking of merging this more these days. Please let me know if anyone want to take a deeper look 🙂 |
This was referenced May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves: #39127
This PR adds the
job_idparameter toBigQueryGetDataOperatorto fetch data from the results of selection queries executed byBigQueryInsertJobOperator(or any other querying interfaces). The new parameter is mutually exclusive withtable_idand its related parameters (dataset_idanduse_legacy_sql).After merging this PR, the original issue of fetching results from complex queries (for example, queries with
ORDER BYclauses) will be solved by running two operators sequentially:BigQueryInsertJobOperatorBigQueryGetDataOperatorwhile providingjob_idfrom the previous step (templated):job_id = "{{ task_instance.xcom_pull(task_ids='insert_job_op', key='return_value') }}"^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.