Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pytest to 8.2+ #39450

Merged
merged 2 commits into from
May 8, 2024
Merged

Bump pytest to 8.2+ #39450

merged 2 commits into from
May 8, 2024

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented May 6, 2024

closes #37156

The issues mentioned in the above meta-task are fixed


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes labels May 6, 2024
@eladkal
Copy link
Contributor

eladkal commented May 6, 2024

There was an attempt in #37151 it required several changes to some tests

@kaxil kaxil marked this pull request as draft May 6, 2024 21:31
@Taragolis
Copy link
Contributor

There is less incompatibility then we have before.
I also would recommend to bump minimal version to 8.1.x or even 8.2.x, there is plenty of the bugs in 8.0.x
And maybe upper bound to <9, every time we need some time for adopt our tests to the changes in major pytest version

@kaxil kaxil force-pushed the bump-pytest branch 3 times, most recently from 83238cf to 692fa9e Compare May 7, 2024 20:20
@kaxil kaxil changed the title Bump pytest to 8.0+ Bump pytest to 8.2+ May 7, 2024
kaxil added a commit to astronomer/airflow that referenced this pull request May 8, 2024
This wasted a lot of my hours in debugging failures for apache#39450

This was modifying a global env vars and causing side effects in other tests
@kaxil kaxil marked this pull request as ready for review May 8, 2024 01:37
@kaxil kaxil requested review from eladkal and o-nikolas as code owners May 8, 2024 01:37
@kaxil kaxil requested a review from Lee-W May 8, 2024 01:39
@kaxil
Copy link
Member Author

kaxil commented May 8, 2024

Hopefully fixed all the issues 🤞

closes apache#37156

The issues mentioned in the above meta-task are fixed
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance. But let's wait for the CI. Also, should we add "full test needed" label?

@kaxil kaxil added the full tests needed We need to run full set of tests for this PR to merge label May 8, 2024
pankajkoti pushed a commit that referenced this pull request May 8, 2024
This wasted a lot of my hours in debugging failures for #39450

This was modifying a global env vars and causing side effects in other tests
@kaxil kaxil merged commit 34e93ea into apache:main May 8, 2024
3 checks passed
@kaxil kaxil deleted the bump-pytest branch May 8, 2024 09:35
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
This wasted a lot of my hours in debugging failures for apache#39450

This was modifying a global env vars and causing side effects in other tests
pateash pushed a commit to pateash/airflow that referenced this pull request May 13, 2024
closes apache#37156

The issues mentioned in the above meta-task are fixed
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Jun 3, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.10.0 milestone Jun 4, 2024
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 9, 2024
This wasted a lot of my hours in debugging failures for apache/airflow#39450

This was modifying a global env vars and causing side effects in other tests

GitOrigin-RevId: 9a50475121a1ff5b82bd93c39c3ed1c845bd95ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools area:production-image Production image improvements and fixes full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for pytest 8.0.0+
6 participants