Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing deprecation postgres #39706

Merged
merged 1 commit into from
May 22, 2024

Conversation

Bowrna
Copy link
Contributor

@Bowrna Bowrna commented May 20, 2024

Related: #39485
Removing deprecated PostgresOperator from docs and tests and replacing with SQLExecuteQueryOperator


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Taragolis
Copy link
Contributor

Looks really nice!

I would suggest to keep information about PostgresOperator into the documentation, e.g. in warning block
This might help users who try to search PostgresOperator via search engines (e.g. in google).
In this case, potentially, it come to the current version documentation page, otherwise it might show old version of provider.

Something like that

.. warning::
    Previously, PostgresOperator was used to perform this kind of operation. But at the moment PostgresOperator is deprecated and will be removed in future versions of the provider. Please consider to switch to SQLExecuteQueryOperator as soon as possible.

@Bowrna Bowrna force-pushed the remove_deprecation_postgres branch from 06e160e to 2f15a3f Compare May 21, 2024 05:55
@Bowrna
Copy link
Contributor Author

Bowrna commented May 21, 2024

@Taragolis I have added the warning part in docs. Let me know if it looks good now. Will do the same for the other DB related providers too!

@Bowrna Bowrna force-pushed the remove_deprecation_postgres branch from 2f15a3f to 184e829 Compare May 21, 2024 06:28
@Taragolis Taragolis merged commit cb57a67 into apache:main May 22, 2024
42 checks passed
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants