-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish Dataproc Serverless Batch link after it starts if batch_id was provided #41153
Conversation
8fa714b
to
f2d8f84
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Please unstale. Hopefully in thousand years someone will look into it... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes we might oversee PRs - in that case, you could always ping us at the #new-contributors channel on Slack.
I had some minor comments, and I'd be happy if you could add/update a relevant test.
Thank you!
@rafalh can you address comments and resolve conflicts? |
f2d8f84
to
c38e5d4
Compare
c38e5d4
to
c0b28c5
Compare
Sorry for the delay. I resolved the conflicts and I think it is ready for re-review. |
Currently the link to Dataproc Serverless Batch is only available after its successful execution.
To improve user experience publish a link right after the batch starts execution if
batch_id
was provided. It makes it easier to observe the progress and find batch logs when it fails.The only drawback is that if batch creation fails before it starts execution, the link will point to nowhere, but I think it is acceptable considering the gains.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.