Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubernetesHook kube_config extra can take dict #41413

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Aug 12, 2024

Previously had to be json-encoded string which is less convenient when defining the conn in json.

E.g. before only this works

AIRFLOW_CONN_KUBERNETES_DEFAULT='{"extra":{"cluster_context":"orbstack","kube_config":"{\"kind\":\"Config\",...

But after, now this also works:

AIRFLOW_CONN_KUBERNETES_DEFAULT='{"extra":{"cluster_context":"orbstack","kube_config":{"kind":"Config",...

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Sep 30, 2024
dstandish and others added 2 commits September 30, 2024 04:36
Previously had to be json-encoded string which is less convenient when defining the conn in json.
@dstandish dstandish force-pushed the k8s-hook-kube-config-can-be-dict branch from 5f282d9 to 15216a6 Compare September 30, 2024 11:37
@dstandish dstandish merged commit 6808619 into apache:main Sep 30, 2024
67 checks passed
@dstandish dstandish deleted the k8s-hook-kube-config-can-be-dict branch September 30, 2024 15:58
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
Previously had to be json-encoded string which is less convenient when defining the conn in json.

---------

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Previously had to be json-encoded string which is less convenient when defining the conn in json.

---------

Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants