-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KubernetesHook kube_config extra can take dict #41413
Merged
dstandish
merged 2 commits into
apache:main
from
astronomer:k8s-hook-kube-config-can-be-dict
Sep 30, 2024
Merged
KubernetesHook kube_config extra can take dict #41413
dstandish
merged 2 commits into
apache:main
from
astronomer:k8s-hook-kube-config-can-be-dict
Sep 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
requested review from
jedcunningham and
hussein-awala
as code owners
August 12, 2024 20:31
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Kubernetes provider related issues
labels
Aug 12, 2024
kaxil
approved these changes
Aug 13, 2024
jedcunningham
approved these changes
Aug 13, 2024
amoghrajesh
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Stale PRs per the .github/workflows/stale.yml policy file
label
Sep 30, 2024
Previously had to be json-encoded string which is less convenient when defining the conn in json.
dstandish
force-pushed
the
k8s-hook-kube-config-can-be-dict
branch
from
September 30, 2024 11:37
5f282d9
to
15216a6
Compare
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
Previously had to be json-encoded string which is less convenient when defining the conn in json. --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
Previously had to be json-encoded string which is less convenient when defining the conn in json. --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:providers
provider:cncf-kubernetes
Kubernetes provider related issues
stale
Stale PRs per the .github/workflows/stale.yml policy file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously had to be json-encoded string which is less convenient when defining the conn in json.
E.g. before only this works
But after, now this also works: