Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add OpenLineage support to S3ToRedshiftOperator #41422

Closed

Conversation

Artuz37
Copy link
Contributor

@Artuz37 Artuz37 commented Aug 13, 2024


Added get_openlineage_facets_on_complete method to S3ToRedshiftOperator.
It extracts target table schema by querying redshift and creates identity column level lineage.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:amazon-aws AWS/Amazon - related issues labels Aug 13, 2024
Copy link

boring-cyborg bot commented Aug 13, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@Artuz37 Artuz37 marked this pull request as ready for review August 13, 2024 12:40
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Artuz37 and others added 16 commits August 16, 2024 13:39
…#41414)

* Fix tests/models/test_variable.py for database isolation mode

* Review feedback
This PR removes SubDags in favor of TaskGroups fro Airflow 3.0

Subdags have been removed from the following locations:

- CLI
- API
- ``SubDagOperator``

This removal marks the end of Subdag support across all interfaces. Users
should transition to using TaskGroups as a more efficient and maintainable
alternative.

---------
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Previously if we ever needed to get the current span and manipulate it, we needed to name it with leading or trailing underscores to avoid collisions with the span decorator function name, which was a bit awkward.
The exception should be `ExportTaskNotFound` (and not
`ExportTaskNotFoundFault`) as recorded here:
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeExportTasks.html

The moto version dependency pin is updated to reflect this.
Older versions of moto will not succeed this test case, hence the
version pin is bumped to 5.0.12

Co-authored-by: Vikram Gaonkar <vikramaditya.gaonkar@imc.com>
…ert in system test (apache#41303)

* use bulk upsert in system test

* fix bulk_upsert test
* Remove deprecated and unused methods / properties on DAG

(cherry picked from commit 6bd4f83062151d427dab764bca123ba396eda6c0)

* add newsfragment

* fix test

* fix test

* Fix formatting

---------

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
morokosi and others added 11 commits August 19, 2024 09:44
* restore python 3.12 support for papermill

* update provider_dependencies.json
…r and policy removal (apache#41550)

* airflow deprecated settings session_lifetime_days, force_log_out_after and policy removal

* news fragment added

* news fragment updated

* news fragment updated

* news fragment updated
* smtp email user and password deprecated config removal

* smtp email user and password deprecated config removal

* news fragment added

* smtp email user and password deprecated config removal
…pache#41488)

When running tests for providers with old Airflow versions, we have
to make sure to uninstall all packages before installing old Airflow
versions - because some of the packages can be installed by new
Airflow version and they are missing in the old Airflow version.

This has already happened in apache#41402 with methodtools.

This PR adds `--clean-airflow-installation` flag to relevant breeze
commands that install other airflow version. This is quite a bit
slower as it requires to uninstall and reinstall packages so we
do not set it by default.
…apache#41096)

* processor_poll_interval deprecated parameter usage removal

* news fragment added

* news fragment added

* news fragment added

* Update newsfragments/41096.significant.rst

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>

* Update 41096.significant.rst

---------

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.