fix(dag): avoid getting dataset next run info for unresolved dataset alias #41828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Aug 30, 2024
Lee-W
force-pushed
the
avoid-getting-dataset-next-run-info-for-unresolved-dataset
branch
2 times, most recently
from
eabcedb
to
65b373e
Compare
Lee-W
force-pushed
the
avoid-getting-dataset-next-run-info-for-unresolved-dataset
branch
from
65b373e
to
566b68b
Compare
…th_unresolved_dataset_alias"
Lee-W
force-pushed
the
avoid-getting-dataset-next-run-info-for-unresolved-dataset
branch
from
566b68b
to
232215d
Compare
sounds good. just added it. will merge this one once CI passed |
Lee-W
deleted the
avoid-getting-dataset-next-run-info-for-unresolved-dataset
branch
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In #41453, we change the condition to get dataset next run info from
self.schedule_interval != "Dataset"toself.dataset_expression is None:which won't work for "Unresolved Dataset Alias" as they don't have dataset info to get yet.What
Do not get dataset next run info if it's an unresolved dataset alias
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.