Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All executors should inherit from BaseExecutor #41904

Merged
merged 4 commits into from
Oct 2, 2024
Merged

All executors should inherit from BaseExecutor #41904

merged 4 commits into from
Oct 2, 2024

Conversation

dstandish
Copy link
Contributor

@dstandish dstandish commented Aug 30, 2024 •
edited
Loading

Here I amend LocalKubernetesExecutor and CeleryKubernetesExecutor to inherit from BaseExecutor.

resolves: #41891

@boring-cyborg boring-cyborg bot added area:Executors-core LocalExecutor & SequentialExecutor area:providers provider:celery provider:cncf-kubernetes Kubernetes provider related issues labels Aug 30, 2024
@dstandish dstandish mentioned this pull request Aug 30, 2024
Closed
2 tasks
@dstandish dstandish modified the milestone: Airflow 2.10.1 Aug 30, 2024
@potiuk
Copy link
Member

potiuk commented Aug 30, 2024

If I am not mistaken that means that currently released cncf.kubernetes providers will not work well with 2.10 and 2.10.1 ?. Should we also make a compatibility check / workaround (and backport it to 2.10.1) so that older provider versions' executors work as well with 2.10.1 ?

@dstandish
Copy link
Contributor Author

If I am not mistaken that means that currently released cncf.kubernetes providers will not work well with 2.10 and 2.10.1 ?. Should we also make a compatibility check / workaround (and backport it to 2.10.1) so that older provider versions' executors work as well with 2.10.1 ?

Yeah makes sense, done that here #41906

@potiuk
Copy link
Member

potiuk commented Sep 1, 2024

To me this abomination isn't an executor, only the sub executors are valid executors. But also, they won't last long until they're removed so I suppose it's not a big deal either way! Happy to approve.

We'll have to live with them for at least 18 months "officiailly", I am afraid and they will survive it for a much longer time ... That's the reality we are facing :(

potiuk
potiuk approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we merge it ?

@eladkal
Copy link
Contributor

eladkal commented Sep 17, 2024

@dstandish ready for merge?

@dstandish
Copy link
Contributor Author

Shall we merge it ?

Yeah should be fine I think!

@potiuk
Copy link
Member

potiuk commented Oct 1, 2024

Yeah should be fine I think!

What holds you back @dstandish :) ?

@dstandish
Copy link
Contributor Author

Yeah should be fine I think!

What holds you back @dstandish :) ?

I guess just was hoping i'd get some conflicts to resolve :)

@dstandish dstandish merged commit c72dad7 into apache:main Oct 2, 2024
66 checks passed
@dstandish dstandish deleted the cke-to-inherit-base-executor branch October 2, 2024 02:23
@eladkal eladkal mentioned this pull request Oct 10, 2024
Closed
96 tasks
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
@dstandish @joaopamaral
All executors should inherit from BaseExecutor (apache#41904)
5600388
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
@dstandish @ellisms
All executors should inherit from BaseExecutor (apache#41904)
b155f45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheffl jscheffl jscheffl approved these changes

@o-nikolas o-nikolas o-nikolas approved these changes

@potiuk potiuk potiuk approved these changes

@jedcunningham jedcunningham Awaiting requested review from jedcunningham

@hussein-awala hussein-awala Awaiting requested review from hussein-awala

@kaxil kaxil Awaiting requested review from kaxil

@XD-DENG XD-DENG Awaiting requested review from XD-DENG

@ashb ashb Awaiting requested review from ashb

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun

Assignees
No one assigned
Labels
area:Executors-core LocalExecutor & SequentialExecutor area:providers provider:celery provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'CeleryKubernetesExecutor' object has no attribute '_task_event_logs'
5 participants
@dstandish @potiuk @eladkal @o-nikolas @jscheffl