-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle ClientError raised after key is missing during DyanmoDB table.get_item #42408
handle ClientError raised after key is missing during DyanmoDB table.get_item #42408
Conversation
We are having some canary build failure around dynamo db:
https://github.com/apache/airflow/actions/runs/10989610037/job/30508381216#step:7:4458 Looks like Added canary and upgrade labels to rerun the CI with the updated versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks reasonable.
Could you add/update unit test to cover this new branch? |
Fixed in #42419 |
… during table.get_item
85ded41
to
06e3dfd
Compare
Sure! just added |
Thanks! This one was originally meant to solve that, but seems to be the wrong fix 🤦♂️ |
… during table.get_item (apache#42408)
… during table.get_item (apache#42408)
Why
Since moto 5.0.15, it validates whether the key exists which might indicate we does not check whether the key exist in our sensor.
What
Add an additional check to handle boto ClientError
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.