Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated stuff from Amazon provider package #42450

Merged
merged 11 commits into from
Sep 26, 2024

Conversation

vincbeck
Copy link
Contributor

A new major version will be released in the Amazon provider package (see breaking change in #42218). As such, it is a good time to do some clean up.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck
Copy link
Contributor Author

Tests are expected to fail. I'll resolve them

@eladkal
Copy link
Contributor

eladkal commented Sep 25, 2024

We need change log entry explaining what we broke (list of items)

Copy link
Contributor

@o-nikolas o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a few spot checks, it's a large PR, but what I looked at seems good and the tests passing.

@vincbeck
Copy link
Contributor Author

vincbeck commented Sep 26, 2024

@eladkal Could you check that the changelog looks good to you?

@vincbeck vincbeck merged commit 5681622 into apache:main Sep 26, 2024
55 checks passed
@vincbeck vincbeck deleted the vincbeck/deprecate branch September 26, 2024 15:40
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants