Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snowpark operator and decorator #42457

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Add Snowpark operator and decorator #42457

merged 6 commits into from
Oct 3, 2024

Conversation

sfc-gh-jdu
Copy link
Contributor


closes: #24456

This is the first step of adding Snowpark-related operators and decorators. We will add more in the following PRs (e.g., running snowpark in virtual env). This PR also includes unit tests, system tests and documentation changes.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link

boring-cyborg bot commented Sep 24, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@sfc-gh-jdu
Copy link
Contributor Author

sfc-gh-jdu commented Sep 30, 2024

Could anyone please take a look? Thanks!

@potiuk
Copy link
Member

potiuk commented Oct 1, 2024

Could anyone please take a look? Thanks!

I think there is a problem with dependencies that causes PROD build to fail

@potiuk
Copy link
Member

potiuk commented Oct 1, 2024

Or simply rebase might fix it.

@sfc-gh-jdu
Copy link
Contributor Author

Could anyone please take a look? Thanks!

I think there is a problem with dependencies that causes PROD build to fail

Yeah I checked CI failures last week, it seems unrelated. I rebased once but got some new failures you saw here. @jscheffl Thanks for rebasing it!

@sfc-gh-jdu
Copy link
Contributor Author

Or simply rebase might fix it.

Or simply rebase might fix it.

All merge gates are green now. Can you please take a look when you get a chance? Thanks!

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no real expertise with Snowflake/Snowpark, generally the cod elooks OK but can not judge functional correctness. Second eye review requested before merge.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Though also - I do not know details of Snowflake integration.

Speaking of which.....

Maybe it is a good idea that Snowflake team implements System Tests and system test dashboard similar to the ones that Amazon, Google. Astronomer and Teradata did (see https://airflow.apache.org/ecosystem/#airflow-provider-system-test-dashboards )

We had a talk about it at Airflow Summit (recording will be published soon) where the authors of such dashboard explained what benefit it brings to them and that might be a great way to make sure that the quality of integration with Snowflake is maintained over time.

See https://airflowsummit.org/sessions/2024/hello-quality-building-cis-to-run-providers-packages-system-tests/ for description of the talk (recordings should be avaoilable at this link soon)

@potiuk potiuk merged commit 976064d into apache:main Oct 3, 2024
110 checks passed
Copy link

boring-cyborg bot commented Oct 3, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@sfc-gh-jdu
Copy link
Contributor Author

LGTM as well. Though also - I do not know details of Snowflake integration.

Speaking of which.....

Maybe it is a good idea that Snowflake team implements System Tests and system test dashboard similar to the ones that Amazon, Google. Astronomer and Teradata did (see https://airflow.apache.org/ecosystem/#airflow-provider-system-test-dashboards )

We had a talk about it at Airflow Summit (recording will be published soon) where the authors of such dashboard explained what benefit it brings to them and that might be a great way to make sure that the quality of integration with Snowflake is maintained over time.

See https://airflowsummit.org/sessions/2024/hello-quality-building-cis-to-run-providers-packages-system-tests/ for description of the talk (recordings should be avaoilable at this link soon)

Yes! @mik-laj already told me that and I'm working on such a dashboard now

@potiuk
Copy link
Member

potiuk commented Oct 4, 2024

Yes! @mik-laj already told me that and I'm working on such a dashboard now

👀 👀 👀 👀 👀 👀 👀 👀

ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Snowpark Operator that allows execution of Snowflake Snowpark code
3 participants