Update Rest API tests to no longer rely on FAB auth manager. Move tests specific to FAB permissions to FAB provider #42523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts specific to FAB permissions to FAB provider This reverts commit 770c9db8fd2cdb6bcffd9cb951c916b4b25a9917.
boring-cyborg
bot
added
area:API
vincbeck
requested review from
potiuk,
kaxil,
XD-DENG and
ashb
as code owners
vincbeck
force-pushed
the
vincbeck/rest_api_tests
branch
from
4f35bc0
to
dcc005d
Compare
jscheffl
reviewed
Sep 30, 2024
jscheffl
approved these changes
Sep 30, 2024
|
WHOA! Fantastic. |
96 tasks
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…ts specific to FAB permissions to FAB provider (apache#42523)
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…ts specific to FAB permissions to FAB provider (apache#42523)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests in
tests/api_connexion/endpoints/rely on FAB permission model. Since we want to get rid of FAB, we need to make these tests agnostic from FAB. In this PR, they are now using simple auth manager.I did two things:
tests/api_connexion/endpoints/and make them agnostic from FABThis PR is quite big but I could not find a way to make it smaller. Here are some tips for a quicker review:
tests/api_connexion/endpoints/is removing tests that use granular permissionstests/providers/fab/auth_manager/api_endpoints/is tests being copy pasted fromtests/api_connexion/endpoints/that use granular permissions (the ones that are removed in the previous step)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.