better docs can save time #42832
Merged
better docs can save time #42832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon-aws
kaxil
approved these changes
Oct 8, 2024
zachliu
deleted the
update-docs-on-storing-google-secrets-in-aws-secrets-manager
branch
|
Nice! |
kunaljubce
pushed a commit
to kunaljubce/airflow
that referenced
this pull request
Oct 13, 2024
…42832) The [existing documentation](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/secrets-backends/aws-secrets-manager.html#example-of-storing-google-secrets-in-aws-secrets-manager) on how to set up Google secrets in AWS Secrets Manager is out of date. It led me on a merry chase for hours. I hereby submit this PR to update the doc. I solemnly swear that the content has been verified using DAG code similar to this ```python gsheet = GSheetsHook(gcp_conn_id=gcp_conn_id) values = gsheet.get_values( spreadsheet_id=spreadsheet_id, range_=f"{sheet_name}!B1:B2", ) `
pavansharma36
pushed a commit
to pavansharma36/airflow
that referenced
this pull request
Oct 14, 2024
…42832) The [existing documentation](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/secrets-backends/aws-secrets-manager.html#example-of-storing-google-secrets-in-aws-secrets-manager) on how to set up Google secrets in AWS Secrets Manager is out of date. It led me on a merry chase for hours. I hereby submit this PR to update the doc. I solemnly swear that the content has been verified using DAG code similar to this ```python gsheet = GSheetsHook(gcp_conn_id=gcp_conn_id) values = gsheet.get_values( spreadsheet_id=spreadsheet_id, range_=f"{sheet_name}!B1:B2", ) `
joaopamaral
pushed a commit
to joaopamaral/airflow
that referenced
this pull request
Oct 21, 2024
…42832) The [existing documentation](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/secrets-backends/aws-secrets-manager.html#example-of-storing-google-secrets-in-aws-secrets-manager) on how to set up Google secrets in AWS Secrets Manager is out of date. It led me on a merry chase for hours. I hereby submit this PR to update the doc. I solemnly swear that the content has been verified using DAG code similar to this ```python gsheet = GSheetsHook(gcp_conn_id=gcp_conn_id) values = gsheet.get_values( spreadsheet_id=spreadsheet_id, range_=f"{sheet_name}!B1:B2", ) `
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
…42832) The [existing documentation](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/secrets-backends/aws-secrets-manager.html#example-of-storing-google-secrets-in-aws-secrets-manager) on how to set up Google secrets in AWS Secrets Manager is out of date. It led me on a merry chase for hours. I hereby submit this PR to update the doc. I solemnly swear that the content has been verified using DAG code similar to this ```python gsheet = GSheetsHook(gcp_conn_id=gcp_conn_id) values = gsheet.get_values( spreadsheet_id=spreadsheet_id, range_=f"{sheet_name}!B1:B2", ) `
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…42832) The [existing documentation](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/secrets-backends/aws-secrets-manager.html#example-of-storing-google-secrets-in-aws-secrets-manager) on how to set up Google secrets in AWS Secrets Manager is out of date. It led me on a merry chase for hours. I hereby submit this PR to update the doc. I solemnly swear that the content has been verified using DAG code similar to this ```python gsheet = GSheetsHook(gcp_conn_id=gcp_conn_id) values = gsheet.get_values( spreadsheet_id=spreadsheet_id, range_=f"{sheet_name}!B1:B2", ) `
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing documentation on how to set up Google secrets in AWS Secrets Manager is out of date. It led me on a merry chase for hours.
I hereby submit this PR to update the doc. I solemnly swear that the content has been verified using DAG code similar to this
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.